Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit temperature for radiation #3124

Merged
merged 1 commit into from
Jun 22, 2024
Merged

limit temperature for radiation #3124

merged 1 commit into from
Jun 22, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Jun 21, 2024

Purpose

Limit the temperature input to RRTMGP so that they fall into the lookup table range

To-do

  • Use ClimaParams

Content


  • I have read and checked the items on the review checklist.

@Sbozzolo
Copy link
Member

Sbozzolo commented Jun 21, 2024

This should be handled by RRMTPGP, otherwise we would have to reimplement this everywhere.

@szy21 szy21 force-pushed the zs/rad_limitt branch 2 times, most recently from 5bab1de to 35f3a5a Compare June 21, 2024 22:22
@szy21 szy21 marked this pull request as ready for review June 21, 2024 22:22
@szy21
Copy link
Member Author

szy21 commented Jun 21, 2024

I will keep the limit here for now, but I opened an issue in rrtmgp: CliMA/RRTMGP.jl#509.

@szy21 szy21 enabled auto-merge June 21, 2024 23:36
@szy21 szy21 added this pull request to the merge queue Jun 22, 2024
Merged via the queue into main with commit d5fc59a Jun 22, 2024
10 of 11 checks passed
@szy21 szy21 deleted the zs/rad_limitt branch June 22, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants