Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix surface_conditions #3064

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix surface_conditions #3064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion regression_tests/ref_counter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
162
163

# 163:
# - Fixed bug introduced in 162

# 162:
# - Changed the order of operations in surface conditions calculation.
Expand Down
2 changes: 1 addition & 1 deletion src/surface_conditions/surface_conditions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ vector_from_component(f₁, L::Geometry.LocalGeometry) =
function tensor_from_components(f₁₃, f₂₃, L, n₃ = surface_normal(L))
xz = CT12(CT1(unit_basis_vector_data(CT1, L)), L)
yz = CT12(CT2(unit_basis_vector_data(CT2, L)), L)
f = C12(f₁₃ * xz + f₂₃ * xz, L)
f = C12(f₁₃ * xz + f₂₃ * yz, L)
return n₃ ⊗ f
end

Expand Down
Loading