-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up ci and gpu scaling config files #2948
Conversation
Hmm, some configs are used in both ci and GPU scaling pipeline. That means we should probably clean it up - if it's already running in ci then we don't need to run it in weekly scaling pipeline again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that there was a difference between the gpu and scaling pipelines. I'm going to add @sriharshakandala as a reviewer for this
The GPU scaling pipeline runs on the A100s. This may not be the case with the GPU runs on the standard CI pipeline, which most likely uses a P100 GPU! |
Yes, I guess it’s ok to run it twice for now. I mostly want to reorganize the files in this PR. We can clean up the jobs later. |
@sriharshakandala are you ok with this folder change, or do you want to keep all of them in the same folder? |
Could you please add an entry to the NEWS.md for this PR? |
One way is to keep the |
Ok, I can do that! |
@sriharshakandala could you look at it again? @juliasloan25 I don't think it's a breaking change anymore if I change it this way (unless you use anything in |
We don't use Atmos's |
1d0b27a
to
da2eaae
Compare
Purpose
Currently we have config files under
gpu_configs
that are used for both ci and GPU scaling pipeline. I find it a bit confusing when trying to find the files and add new files. This PR moves GPU scaling pipeline config files to a new foldergpu_scaling_configs
.This is probably a breaking change as I think the coupler assumes some path of atmos configs. cc @juliasloan25
To-do
Content