Fix some allocations and gpu moist example #1882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/allocs
branch
2 times, most recently
from
6303e6c to
9cf3730
Compare
charleskawczynski
force-pushed
the
ck/allocs
branch
from
9cf3730 to
54e3e06
Compare
trontrytel
approved these changes
Jul 17, 2023
Closed
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2023
1882: Fix some allocations and gpu moist example r=simonbyrne a=charleskawczynski This PR should fix some allocations due to JuliaLang/julia#50554 Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
|
@simonbyrne, I think we unfortunately can't merge this until CliMA/ClimaCore.jl#1380 is merged and we update to the latest version. I think the try-catch doesn't work quite the same with StackOverflow errors? |
|
Superseded by #1919 (which did actually merge but github says it didn't) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix some allocations due to JuliaLang/julia#50554