Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mindmap link to README.md #79

Merged
merged 1 commit into from
Nov 6, 2020
Merged

add mindmap link to README.md #79

merged 1 commit into from
Nov 6, 2020

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Oct 29, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files           7        7           
  Lines         440      440           
=======================================
  Hits          348      348           
  Misses         92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b210ee8...29c6374. Read the comment docs.


### Project Mind map
The latest code structure is found at:
https://miro.com/welcomeonboard/j4n8NPSihwQ3X7wjEH7kkitUi6I9deUa5veFV15dCndrTNRZkczGGyIviVjnuAhZ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this link allow anyone to modify the mind map? Since this repo is open source, we should probably limit the functionality to a number of users.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a editable link. I think we either have a read-only option otherwise. I think I am happy to have this open for edits as it stands, but later we can close it off?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS it's been waiting for bors for like 5 days...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it open, I don't think there will be any problems for now. Is there version control though? In case someone tries to delete/modify everything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a link discussing how the owner can set up roles and save a board backup: https://help.miro.com/hc/en-us/articles/360017571194-Roles-in-Miro . We probably want to do the latter at least.

@ilopezgp
Copy link
Contributor

ilopezgp commented Nov 6, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 6, 2020

Build succeeded:

@bors bors bot merged commit af88af3 into master Nov 6, 2020
@bors bors bot deleted the odunbar-patch-1 branch November 6, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants