Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added note to sinusoid docs about phase shift #295

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Apr 1, 2024

Purpose

Addressing #285

Content

  • Adds a sentence clarifying the roles of \phi f G in sinusoid example

See result here


  • I have read and checked the items on the review checklist.

@odunbar odunbar changed the title added note RE phase shift added note to sinusoid docs about phase shift Apr 1, 2024
@odunbar
Copy link
Collaborator Author

odunbar commented Apr 1, 2024

One sentence changed in docs- therefore skipping review for this PR

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (acf1051) to head (9662ce0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   88.17%   88.26%   +0.08%     
==========================================
  Files           8        8              
  Lines        1184     1184              
==========================================
+ Hits         1044     1045       +1     
+ Misses        140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar odunbar merged commit 244d25a into main Apr 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant