-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sinusoidal example #248
Sinusoidal example #248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 88.09% 88.16% +0.07%
==========================================
Files 7 7
Lines 1134 1124 -10
==========================================
- Hits 999 991 -8
+ Misses 135 133 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lm2612 This looks really good so far. I have focussed just on the Docs for now, I'll take a peak at the RF setup etc. in a bit. It's mostly minor comments, although there is one larger comment.
- I find the marginal GP/RF validation plots quite opaque. It's very hard to interpret how far the data is from the training points etc. as only ordering in one axis is not very clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lm2612
A review on the example itself:
- The difference in performance is due to it not being a fair experiment, I have detailed the small fix, and I observe this balances out the behaviour significantly. though the RF still has a heavier tail for theta_1 (Note RF still learns the noise where GP doesnt)
Another Kernel that performs very similarly to GP is the following vector-RF case without decorrelation:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this is a fantastic example! Please run the julia formatter - otherwise my comments are very minor.
Then we can squash&merge
616ffa4
to
fc42bdb
Compare
…usoidal example. This example is 2d->2d for a model of a sinusoid that depends on 2 parameters (amplitude, vertical shift) and given a system where we make noisy observations of its range and mean position. New files in example: * Setup script (functions defined for the true model) * Calibrate (using ensemble kalman inversion) * Emulate (using GP, RF and emulator validation plots) * Sample (with mcmc and plotting 2d posteriors). New docs under page Simple example walkthrough: a walkthrough of these scripts with plots for each step.
fc42bdb
to
ab5a875
Compare
Purpose
This will close #247
To-do
Content