fix testing bugs #208
Merged
fix testing bugs #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging without review as this simply bug-fixes tests and no changes to interface |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2023
208: fix testing bugs r=odunbar a=odunbar <!--- THESE LINES ARE COMMENTED --> ## Purpose <!--- One sentence to describe the purpose of this PR, refer to any linked issues: #14 -- this will link to issue 14 Closes #2 -- this will automatically close issue 2 on PR merge --> No direct issue. Bugs found during other testing, - scikit learn leads to conda issues (i.e. trying to install a non-existent package (`libstdcxx-ngnothing`) presumably due to some typo internally, or "broken SAT solver" message due to pycosat) - `MarkovChainMonteCarlo`s `sample()` export leads to test breaking in some julia versions - GP test fails due to random seed changes ## Content <!--- specific tasks that are currently complete - Solution implemented --> - removes `@sk_learn` macro, which ignored the installed Conda/PyCall and created its own (buggy) installation of conda. Instead, always uses `PyCall` - adds `MCMC.sample` qualifier in tests - loosens GP tolerances for more robust testing under different random seeds <!--- Review checklist I have: - followed the codebase contribution guide: https://clima.github.io/ClimateMachine.jl/latest/Contributing/ - followed the style guide: https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/ - followed the documentation policy: https://github.com/CliMA/policies/wiki/Documentation-Policy - checked that this PR does not duplicate an open PR. In the Content, I have included - relevant unit tests, and integration tests, - appropriate docstrings on all functions, structs, and modules, and included relevant documentation. --> ---- - [x] I have read and checked the items on the review checklist. Co-authored-by: odunbar <[email protected]>
|
Build failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
remove sample() ambiguity in test GP robust test tol add condaforge try add conda-forge try changing Python/conda paths format...;
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
No direct issue. Bugs found during other testing,
libstdcxx-ngnothing) presumably due to some typo internally, or "broken SAT solver" message due to pycosat)MarkovChainMonteCarlossample()export leads to test breaking in some julia versionsContent
PyCallMCMC.samplequalifier in tests