Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulator/Data processing docs #144

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Emulator/Data processing docs #144

merged 2 commits into from
Jun 17, 2022

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented May 30, 2022 •
edited
Loading

Purpose

To add docs page requested in #136: view here

In this PR

Docs for the Emulator object, focusing on

  • The optional arguments for data processing (SVD, normalization, standardization)
  • The modular emulator interface (how to add a new statistical emulator tool)
  • Does not go into details of the exact emulator (i.e doesn't talk about GP)

@odunbar odunbar requested a review from lm2612 May 30, 2022 20:12
@codecov
Copy link

codecov bot commented May 30, 2022 •
edited
Loading

Codecov Report

Merging #144 (75a5b73) into master (ad38cb5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files           4        4           
  Lines         380      380           
=======================================
  Hits          335      335           
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad38cb5...75a5b73. Read the comment docs.

@odunbar odunbar requested a review from mhowlan3 May 31, 2022 17:15
lm2612
lm2612 approved these changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@lm2612 lm2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@odunbar
Copy link
Collaborator Author

odunbar commented Jun 17, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 17, 2022

Build succeeded:

@bors bors bot merged commit 052fc44 into master Jun 17, 2022
@bors bors bot deleted the orad/em-docs branch June 17, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lm2612 lm2612 lm2612 approved these changes

@mhowlan3 mhowlan3 Awaiting requested review from mhowlan3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odunbar @lm2612