-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize on julia 1.6.x #126
Conversation
OK let's try this patch to get the buildkite moving along |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will likely change on releasing the package, but is fine for compatability now
bors r+ |
Build failed: |
Thanks for the approval, @jakebolewski and @odunbar -- apologies things are still broken! One of you will need to check which environment modules are available in order to fix things: The new CI error the current PR encounters is that the julia executable can't be found (line 103), due to the fact (line 5) that it's
My understanding is that buildkite jobs are running on your own cluster (not containerized), so I'd need one of you to look up the available environment modules on that machine in order to fix this. 1.6.5 was only released a month ago, so it may be premature to expect it to be available. I'm confused by the fact that Oceananigans.jl specifies 1.6.5 in its buildkite setup, yet the CI on |
127: [WIP] Standardize on Julia 1.6.2 r=jakebolewski a=tsj5 This is a revision of PR #126, which ran into a new problem (missing environment module) when attempting to fix #125 (Manifest.toml incompatibility between julia 1.5 and 1.6). See [most recent comment](#126 (comment)) on that PR. Current PR pins the buildkite julia version at 1.6.2, for which a module currently exists. The `Manifest`s in this PR were generated under 1.6.5, and I haven't been able to verify that they're compatible with 1.6.2 (julialang.org didn't retain 1.6.2, and the conda package for 1.6.2 appears to be broken on osx). Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Thomas Jackson <[email protected]>
Resolves #125.
This PR updates environment specs for the project and its examples to use julia 1.6.x, the current long-term support release:
Project.toml
files,Manifest.toml
files to package versions appropriate for julia 1.6.5,