Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding L96 example #101

Merged
merged 14 commits into from
Feb 12, 2021
Merged

Adding L96 example #101

merged 14 commits into from
Feb 12, 2021

Conversation

mhowlan3
Copy link
Contributor

@mhowlan3 mhowlan3 commented Jan 20, 2021 •
edited by odunbar
Loading

Addresses Issue #99
Also Addresses Issue #93
Adds a L96 example. Has a "seasonal" forcing option. RK4 time integration.

@mhowlan3 mhowlan3 requested a review from odunbar January 20, 2021 21:40
@codecov
Copy link

codecov bot commented Feb 2, 2021 •
edited
Loading

Codecov Report

Merging #101 (b0943e1) into master (b19ed8e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   88.80%   88.84%   +0.04%     
==========================================
  Files           7        7              
  Lines         545      547       +2     
==========================================
+ Hits          484      486       +2     
  Misses         61       61
Impacted Files Coverage Δ
src/MarkovChainMonteCarlo.jl 85.71% <100.00%> (+0.27%) ⬆️
src/ParameterDistribution.jl 98.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19ed8e...b0943e1. Read the comment docs.

odunbar
odunbar requested changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Overall we need 2 main changes (1) move the Project/Manifest changes out to the Lorenz directory (2) separate the parameters/settings for the model from the parameters/setting from the learning setup!

Thanks!

Project.toml Outdated Show resolved Hide resolved
examples/Lorenz/Lorenz_example.jl Outdated Show resolved Hide resolved
examples/Lorenz/Lorenz_example.jl Show resolved Hide resolved
examples/Lorenz/Lorenz_example.jl Show resolved Hide resolved
examples/Lorenz/Lorenz_example.jl Outdated Show resolved Hide resolved
@odunbar odunbar changed the title [WIP] Adding L96 example Adding L96 example Feb 5, 2021
odunbar
odunbar approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot Mike

@mhowlan3
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 12, 2021

Build succeeded:

@bors bors bot merged commit 5c8e351 into master Feb 12, 2021
@bors bors bot deleted the mh/seasonal branch February 12, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odunbar odunbar odunbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhowlan3 @odunbar