Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows 32-bit build back in #25

Closed
charleskawczynski opened this issue Feb 3, 2020 · 2 comments
Closed

Add Windows 32-bit build back in #25

charleskawczynski opened this issue Feb 3, 2020 · 2 comments

Comments

@charleskawczynski
Copy link
Member

We had to remove Windows 32-bit build in #22 because, while it seemed to be working up to some point, it was timing out and cannot be increased for non-private builds.

Potential solutions for fixing this seem to be trimming dependencies (especially PyCall/Conda), since only 5-10 minutes are actually needed for testing.
@charleskawczynski charleskawczynski mentioned this issue Feb 3, 2020
Merged
bors bot added a commit that referenced this issue Feb 3, 2020
@bors @charleskawczynski
Merge #22
59edfb2 
22: Add Cloudy example to test r=charleskawczynski a=charleskawczynski

 - Removes "_mb" from filenames
 - Removes Cloudy dependence from CES.jl by passing objects/emthods as arguments from test

I had to remove windows 32-bit build since it was timing out. Opened #25 to track this.

Co-authored-by: Charles Kawczynski <[email protected]>
@dburov190
Copy link
Contributor

I'm not sure we need to care about win32 to be honest... It's very obsolete now, besides, it's Windows :D

@charleskawczynski
Copy link
Member Author

I suspect that it's actually working fine, it's just that we don't know because it's timing out ¯_(ツ)_/¯.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakebolewski @charleskawczynski @dburov190