-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SciKitLearn python backend update breaks GH testing #176
Comments
This is puzzling -- the reason for the broken test appears to be that julia gets linked against one version of libstdc++, while the scikit-learn stuff wants a different version, as described here. The workaround (here) is to modify Aspects I'm unclear on:
|
Pinning the versions of scikit-learn and scipy appears to get the linux test to pass (PR #177). Should we proceed along these lines? |
177: Resolve scikit-learn conflict r=tsj5 a=tsj5 # PULL REQUEST ## Purpose and Content This PR fixes the problems encountered by `@szy21` in #175. The purpose of that PR was to update the Manifest for the examples (Project/Manifest for CES itself is unchanged). This PR uses `@szy21` 's updates and in addition pins the versions of scipy and scikit-learn installed through Conda.jl to avoid an incompatibility in libstdc++ (documented in #176). ## Benefits and Risks **Benefits**: Resolves #176. `@szy21's` original PR resolves #174. **Risks**: Introduces maintenance requirement of having to remember we've pinned the versions of some dependencies going forward; since these are python dependencies this information isn't in Project.toml, so we might forget about this in the future when we want/need to update scikit-learn. This is a very minor risk, as the functionality from sk-learn that we currently use is mature. ## Linked Issues - Closes #174, #176 ## PR Checklist - [X] This PR has a corresponding issue OR is linked to an SDI. - [X] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A. - [X] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy). - [X] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR. - [X] I linted my code on my local machine prior to submission: N/A. - [X] Unit tests: N/A. - [X] Code used in an integration test. - [X] All tests ran successfully on my local machine. - [X] All classes, modules, and function contain docstrings: N/A. - [X] Documentation has been added/updated: N/A. Co-authored-by: szy21 <[email protected]>
177: Resolve scikit-learn conflict r=tsj5 a=tsj5 # PULL REQUEST ## Purpose and Content This PR fixes the problems encountered by `@szy21` in #175. The purpose of that PR was to update the Manifest for the examples (Project/Manifest for CES itself is unchanged). This PR uses `@szy21` 's updates and in addition pins the versions of scipy and scikit-learn installed through Conda.jl to avoid an incompatibility in libstdc++ (documented in #176). ## Benefits and Risks **Benefits**: Resolves #176. `@szy21's` original PR resolves #174. **Risks**: Introduces maintenance requirement of having to remember we've pinned the versions of some dependencies going forward; since these are python dependencies this information isn't in Project.toml, so we might forget about this in the future when we want/need to update scikit-learn. This is a very minor risk, as the functionality from sk-learn that we currently use is mature. ## Linked Issues - Closes #174, #176 ## PR Checklist - [X] This PR has a corresponding issue OR is linked to an SDI. - [X] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A. - [X] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy). - [X] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR. - [X] I linted my code on my local machine prior to submission: N/A. - [X] Unit tests: N/A. - [X] Code used in an integration test. - [X] All tests ran successfully on my local machine. - [X] All classes, modules, and function contain docstrings: N/A. - [X] Documentation has been added/updated: N/A. Co-authored-by: szy21 <[email protected]>
177: Resolve scikit-learn conflict r=odunbar a=tsj5 # PULL REQUEST ## Purpose and Content This PR fixes the problems encountered by `@szy21` in #175. The purpose of that PR was to update the Manifest for the examples (Project/Manifest for CES itself is unchanged). This PR uses `@szy21` 's updates and in addition pins the versions of scipy and scikit-learn installed through Conda.jl to avoid an incompatibility in libstdc++ (documented in #176). ## Benefits and Risks **Benefits**: Resolves #176. `@szy21's` original PR resolves #174. **Risks**: Introduces maintenance requirement of having to remember we've pinned the versions of some dependencies going forward; since these are python dependencies this information isn't in Project.toml, so we might forget about this in the future when we want/need to update scikit-learn. This is a very minor risk, as the functionality from sk-learn that we currently use is mature. ## Linked Issues - Closes #174, #176 ## PR Checklist - [X] This PR has a corresponding issue OR is linked to an SDI. - [X] I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A. - [X] I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy). - [X] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR. - [X] I linted my code on my local machine prior to submission: N/A. - [X] Unit tests: N/A. - [X] Code used in an integration test. - [X] All tests ran successfully on my local machine. - [X] All classes, modules, and function contain docstrings: N/A. - [X] Documentation has been added/updated: N/A. Co-authored-by: szy21 <[email protected]>
Old working version saw conda install
scikit-learn 1.1.1
andscipy 1.8.1
Now conda installs
scikit-learn 1.1.2
andscipy 1.9.0
I suspect the syntax for
pyimport
has changedThe text was updated successfully, but these errors were encountered: