Transformation use action can pick random item from itemgroups #77893
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
mqrause
reviewed
Nov 15, 2024
Comment on lines
+455
to
+457
| if( !target_group.is_empty() ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
That should generate some informative output at least, so you know you can transform it when you look at iteminfo. Ideally a proper description of the item group, but that might be extremely complicated with nested distribution groups, so at least in my opinion some generic sentence would be enough for now.
There was a problem hiding this comment.
I can't even refer to the result output, so I'm not sure what to write here. "Activation can transform into.. Something?"
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Close #76785
Describe the solution
Add such field
Testing
Used the field, seems to work
Additional context
transformation code is very ugly