Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AFS] Dont extract pseudo things for translation #77833

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[AFS] Dont extract pseudo things for translation #77833

merged 2 commits into from
Nov 15, 2024

Conversation

Uwuewsky
Copy link
Contributor

Summary

I18N "[AFS] Add NO_I18N/PREFIX_XL"

Purpose of change

A lot of fake stuff/spells were extracted for translation

Describe the solution

  1. Mark such names with a flag to skip extraction into translation files.
  2. Add PREFIX_XL to a couple things as it was done for the base game.

Describe alternatives you've considered

Testing

The game loads correctly. Marked strings are now missing from .pot file.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Bionics CBM (Compact Bionic Modules) Monsters Monsters both friendly and unfriendly. Mods: Aftershock Anything to do with the Aftershock mod Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing Translation I18n labels Nov 14, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 14, 2024
@Maleclypse Maleclypse merged commit 1323b8b into CleverRaven:master Nov 15, 2024
19 of 26 checks passed
@Uwuewsky Uwuewsky deleted the no-i18n-afs branch November 15, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Translation I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uwuewsky @Maleclypse