Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the monospaced font for the art on the end screen #77494

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

db48x
Copy link
Contributor

@db48x db48x commented Oct 31, 2024

Summary

Interface "use the monospaced font for the ascii art on the end screen"

Purpose of change

because ascii art.

Fixes some of problems in #77297
Fixes #77402

Describe the solution

We have a monospaced font available; use it. Also, vertically align the “Last Words:” label in front of the textbox, so that the baselines of the two are lined up.

Testing

Use Play Now to get a game started. Walk outside and get eaten by zombies or wasps or whatever is handy. Observe the end screen.

Screenshot from 2024-10-31 16-38-35
Screenshot from 2024-10-31 16-51-44

because ascii art. Also, vertically align the “Last Words:” label in
front of the textbox, so that the baselines of the two are lined up.

Partially fixes CleverRaven#77297
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 31, 2024
@ampersand55
Copy link
Contributor

Also directly fixes #77402

@mqrause
Copy link
Contributor

mqrause commented Nov 1, 2024

Partially fixes #77297

Please not that this wording still marks the issue to be closed with the PR.

@db48x
Copy link
Contributor Author

db48x commented Nov 1, 2024

Unrelated test failures :(

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 13, 2024
@ZhilkinSerg ZhilkinSerg merged commit 6545009 into CleverRaven:master Nov 15, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gravestone ascii art in default death screen looks screwed up
4 participants