Faction relationships can be modified through dialogue #77371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
github-actions
bot
added
the
BasicBuildPassed
-Outer fence is no longer permalocked with no way in -You can ask for a gate to be opened.
github-actions
bot
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Faction relationships can be modified through dialogue"
Purpose of change
There are cases where it's inappropriate for a player to interact with a NPC faction's things, but they may later gain permission. e.g. as a reward for performing some task.
There is currently no way to actually grant this permission.
Describe the solution
Make a way to grant these permissions.
Add a new dialogue effect which allows any relationship rule to be set/unset
Had to unfuck some lumbermill stuff while I was here. It was previously locked with no way in (lol). Unlocked the outer gate, added a dialogue option to ask for a gate to be opened. Does NOT actually give you permissions, since otherwise you'd be able to steal their gas.
Describe alternatives you've considered
Make some dialogue access for std::bitset<>flip()?
Testing
It works, it persists through load
Additional context
Hooking it up in a few more places in json, then undraftDone