Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the segfault when trying to exit the Read menu #77229

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fixed the segfault when trying to exit the Read menu #77229

merged 1 commit into from
Oct 21, 2024

Conversation

Night-Pryanik
Copy link
Contributor

Summary

None

Purpose of change

Describe the solution

Put the item the_book = *loc.get_item(); into the if( loc ) check.

Describe alternatives you've considered

None.

Testing

Opened the menu, pressed Esc, no crashes.
Just in case, found a book, read it, no crashes.

Additional context

None.

@Night-Pryanik Night-Pryanik added [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact (P1 - Critical) Highest priority (for ex. crash fixes) <Bugfix> This is a fix for a bug (or closes open issue) labels Oct 21, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 21, 2024
@dseguin dseguin merged commit 2357a3c into CleverRaven:master Oct 21, 2024
27 checks passed
@Night-Pryanik Night-Pryanik deleted the read-segfault branch October 21, 2024 13:31
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 21, 2024
@PatrikLundell PatrikLundell mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact json-styled JSON lint passed, label assigned by github actions (P1 - Critical) Highest priority (for ex. crash fixes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when trying to exit out of Read menu.
2 participants
@Night-Pryanik @dseguin