Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XE] Mad Inventor sandwich recipe #77113

Merged
merged 18 commits into from
Nov 10, 2024

Conversation

Daved27hundred
Copy link
Contributor

@Daved27hundred Daved27hundred commented Oct 18, 2024

Summary

Content "New mad genius recipe for a healing sandwich"

Purpose of change

I fucking love the Mad Inventor. It's such a unique concept. This is the first of possibly many recipes I will be adding. I noticed a distinct lack

Describe the solution

Adds a new recipe unlocked by intermediate research for the "cosmic dagwood," a food item which gives a short regeneration effect on consumption. It takes seven hours to make, uses some unorthodox ingredients, and spoils in ten hours a day which I see as a good enough balance for it. It's meant to be something you make preemptively before embarking on a looting spree somewhere for an emergency.

Describe alternatives you've considered

I could give it different effects.

Testing

The recipe works, the spell works as intended

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 18, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • cosmic dagwood
  • cosmic dagwoods

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added Mechanics: Enchantments / Spells Enchantments and spells BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 20, 2024
@Daved27hundred
Copy link
Contributor Author

A bug(?) is stopping this from progressing any further. I'm gonna have to report it and hope it gets fixed.

@martinrhan

This comment was marked as off-topic.

@kevingranade
Copy link
Member

@martinrhan your tone here is hostile, that's uncalled for and I have very little tolerance for it.

As for your concern about diluting the pool of recipes, that's something to be managed, not reflexively avoided.

@IdleSol
Copy link
Contributor

IdleSol commented Oct 31, 2024

Alternative. Instead of a spell, use a vitamin that has a healing effect.

@Daved27hundred
Copy link
Contributor Author

The bug has been fixed, this is gonna be finalized soon, just need to iron out some more things.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2024
@Daved27hundred Daved27hundred marked this pull request as ready for review November 10, 2024 17:07
@Maleclypse
Copy link
Member

So the regen happens over 15 seconds?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 10, 2024
@Maleclypse Maleclypse merged commit 6efe7a3 into CleverRaven:master Nov 10, 2024
27 of 40 checks passed
@GuardianDll
Copy link
Member

15 seconds, and gonna heal total of 150 hp (so around 25 hp per limb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants