Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Fix snippet codename #76015

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Aug 28, 2024

Summary

Bugfixes "[MoM] Fix snippet codename"

Purpose of change

BURNT NOVEMBER is the code for biokinetic study. NOBLE HORIZON is the code for clairsentient study.

Describe the solution

Change BURNT NOVEMBER to NOBLE HORIZON in the errant snippet.

Fix other typoes.

Describe alternatives you've considered

Testing

Text change only.

Additional context

The point of a codename is that it should not give away what it's referring to and that seems to have worked on me when I was writing.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Lore Game lore, in-game communication. Also the Lore tab. Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 28, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Are we still supposed to be doing experiments? Alright, sure, whatever. I figured throwing things at the wall would be a good way to let off steam, so I got A̶n̶n̶a̶ ̶a̶n̶ H84 and X90 and had them toss increasingly heavier things at the wall. Weirdest thing, size and speed don't relate. X90 can lift 10 kg and H84 can only lift 4 kg, but if they're both throwing pencils, H84 can move them faster. X90 can even lift himself up, though he can't move except up or down. On the other hand, H84 can rotate a ball at something-something RPM, it was faster than X90 anyway. I heard a scream from the labs so I didn't have all my equipment, so I just counted them until I lost count. So we spent a couple hours doing that and we all felt better. Maybe someone in the ruins of civilization can use this for something.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 28, 2024
@Maleclypse Maleclypse merged commit 4696f0d into CleverRaven:master Aug 28, 2024
18 of 24 checks passed
@Standing-Storm Standing-Storm deleted the snippet-fix branch August 28, 2024 21:36
Knut-Aage-Hofseth pushed a commit to Knut-Aage-Hofseth/Cataclysm-DDA that referenced this pull request Aug 29, 2024
* Update snippets_new.json

* Typos

* More typos

* Typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants