Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crude_bronze_nail and adjust others to allow entry to the b… #75942

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

juur
Copy link
Contributor

@juur juur commented Aug 25, 2024

Summary

Content "Minor changes and additional items to allow progression into bronze age."

Purpose of change

Currently, without using iron/steel, progression gets as far as bronze anvil. This patch attempts to unlock subsequent technologies, hopefully keeping balance.

For mods like Innawood this is more of a problem.

Describe the solution

Added a crude_bronze_nail (similar to spike nails) and permitted their use with small sandcasting mold. A few other tweaks were needed to allow crafting of bronze_nails without bronze_nails. The next road block is hotcut and a few other items that need steel/iron, which I think are reasonable to block at.

Describe alternatives you've considered

No other ideas sprang to mind. I didn't think the 'nail spike' type nails would work as ammo, but they could I guess?

Testing

Tested in game with crafting beyond the 'wall' of bronze_nails.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 25, 2024
@Karol1223
Copy link
Contributor

Karol1223 commented Aug 25, 2024

Currently, without using iron/steel, progression gets as far as bronze anvil. This patch attempts to unlock subsequent technologies, hopefully keeping balance.

This is not a concern at all. The goal isn't to allow players to make everything from scratch. If Innawood is facing a problem there, this likely should be adressed in Innawood.

The recipes shouldn't be added to vanilla because the progression doesn't get "far enough". If you have sources that these recipes are valid in reality, then that's a reason to add them to vanilla. I don't know whether your recipes do, but that is something to keep in mind - you are not making a valid reasoning for your change. I can see a crudely shaped piece of metal being valid for a nail punch of tongs, but I have doubts it is fit for the sandcasting mold.

You're also only allowing a single type of forge in the recipe, for some reason? And your recipes are causing an absurd amount of mass loss.

data/json/items/tool/metalworking.json Outdated Show resolved Hide resolved
@juur
Copy link
Contributor Author

juur commented Aug 31, 2024

The recipes shouldn't be added to vanilla because the progression doesn't get "far enough". If you have sources that these recipes are valid in reality, then that's a reason to add them to vanilla. I don't know whether your recipes do, but that is something to keep in mind - you are not making a valid reasoning for your change. I can see a crudely shaped piece of metal being valid for a nail punch of tongs, but I have doubts it is fit for the sandcasting mold.

Making your own nails is very much a 'real life' activity. Re: the casting mold, I was thinking of something akin to this, i.e. quite chunky/thick wooden sides such that a hand made crude nail would just about hold the sides in:

image

You're also only allowing a single type of forge in the recipe, for some reason?

The current bronze_nail recipe uses blacksmithing_standard, I copy/pasted "forge" and "oyx_torch" from there, so it is the same? In game it shows plenty of alts:

image

And your recipes are causing an absurd amount of mass loss.

Thanks. The smallest amount of bronze in the game is 300g, so i've increased the charges & duration to make it wasteful but not quite so crazy.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 31, 2024
@Maleclypse Maleclypse merged commit 858f8bc into CleverRaven:master Sep 5, 2024
20 of 24 checks passed
@juur juur deleted the nail-casting branch September 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants