ImGui to respect fonts.json
#75920
Merged
ImGui to respect fonts.json
#75920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
|
Could this possibly also fix #75818? |
github-actions
bot
added
the
BasicBuildPassed
Don't think so. That seems related to division by zero mentioned in Discord#development yesterday |
github-actions
bot
added
the
astyled
|
Yeah, it's division by zero, but most likely resulting from something like an uninitialized font. |
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "ImGui doesn't respect font settings #73019"
Purpose of change
Fix #73019
Describe the solution
The original
typefacesvector was empty, soensure_unifont_loaded()would makeunifont.ttfthe only font used by ImGui.Now
load_fontsis given the the game's list of typefaces to start with.Describe alternatives you've considered
None.
Testing
Built SDL/Tiles on Windows/MSVC in CMake. It worked, see screenshots.
Additional context
Before
After