Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made human products get human 'vitamin' and vitamin inheritance #75918

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #75540.

Describe the solution

  • Give human_flesh_vitamin to all edible human butchery products.
  • Ditto to mutant humans.
  • Copied "real" vitamins from the base items unless other values were specified.
  • Changed the human_flesh_vitamin usage to mirror the meat_allergen one, i.e. 1 unit assigned. As far as I could see all usages in the code uses binary matches, so it won't change anything in practice.

Describe alternatives you've considered

Try to deal with zombies. Zombie arms and legs really should be tagged as "human". Considered scope creep.
Try to deal with all mutants. It's weird there are no vitamins for poisonous and mutagenic stuff, for instance. Scope creep and requires judgement.

Testing

Debug spawned a human corpse, butchered it fully, and examined the products.

Additional context

I made a quick attempt to use the extend syntax instead of copying vitamins, but it didn't seem to work for vitamins. Didn't bother to pursue this avenue further.
Neither scrap meat or human scrap meat show any real vitamins, presumably because the level is too low, but it's still odd, when the definition is 1 iron.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 24, 2024
@RedMisao
Copy link
Contributor

Thank you for fixing this

@Maleclypse Maleclypse merged commit dcc918e into CleverRaven:master Aug 25, 2024
24 checks passed
@PatrikLundell PatrikLundell deleted the cannibal branch August 25, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most human butchering products aren't considered cannibal food
4 participants