-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second nail into the battery coffin #75865
Conversation
Moving towards real battery names would be lovely.
|
Some tools in items/tool/workshop.json should use tool batteries instead of D's - Angle grinder, cordless drill etc |
Heavy batteries in the game mostly run heavy-duty power tools, so the tool battery is most appropriate imo. |
…terries to match what they are
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Never heard of those ones, yet alone encountered one... EDIT: |
Heavy duty power tools are now plug-in tools instead of using batteries. Currently, only exoskeletons, resonance measuring tool, and UPS have a reasonable use case for heavy batteries, while the rest should be migrated to use plugs. |
Heads up, there's a typo in line 205 of data/json/items/armor/robofac_armor.json |
This comment was marked as off-topic.
This comment was marked as off-topic.
Fixes DDA version due to CleverRaven/Cataclysm-DDA#75865 having removed nice things from DDA yet again. Not only do Omnitech batteries have to be standalone and no longer streamlined by copy-from, but now have to fully replace the standard atomic batteries for Omnitech stuff. Did all this for heavy ones too even though those are still in DDA because zero ability to trust those will stay.
* update batteries * migrate all removed batteries, clean up * sprinkle occasional batteries in boxes around the world * fix density test fail * fix wrong chemistry on some batteries * obsolete medium_disposable_cell, replace current medium_battery_cell(D battery) with modern 18650 battery * fix redefinition of 'itype_medium_battery_cell' * remove light_disposable_cell, change the names and descriptions of baterries to match what they are * migrate light_disposable_cell, astyle battery density test * fix test failures * swap battery to please ups crafting test * swap ids for tool batteries to make more sense (and not replace all ids in the entire game) * migrate removed vehicle parts, fix unreachable cell recipe * fix missed afs battery
Summary
Balance "Small battery edits"
Purpose of change
While most people watch at #75361 and how the game is not very playable after it, i decided it is a great opportunity to do what i wanted to do for a very long time: make our batteries less abstract and actually make sense
Describe the solution
Brought batteries to more real specs - names are intentionally left abstract by Kevin request, for the sake of not dealing with "hey this tool should not accept AA batteries but AAA"
todo:
change the id of batteries?just reused old ids mostlyTesting
Loaded the game, walked around, seems okay
Additional context