Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add earthworms and their delicacies #71804

Merged
merged 8 commits into from
Feb 22, 2024
Merged

add earthworms and their delicacies #71804

merged 8 commits into from
Feb 22, 2024

Conversation

juur
Copy link
Contributor

@juur juur commented Feb 17, 2024

Summary

Content "Add earthworms to the game, as a food source"

Purpose of change

Earthworms are quite nutritious. so would be good to have them in the game. Top soil contains quite a lot, on average, 250 per m2 potentially, and can be cooked into things not totally disgusting

Describe the solution

Create earthworm (1x worm) and earthworm_handful (10x worms). Allow purifying into earthworm_boiled (10x worms), smoking into earthworm_dried and cooking into earthworm_fried. Update digging_soil_loam_50L to have a topsoil variant, and include random worms in it. Add to various existing lists as meat alternative.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map labels Feb 17, 2024
@juur
Copy link
Contributor Author

juur commented Feb 17, 2024

I don't understand why adding this to the itemgroup causes the game to crash on load - am I missing something obvious?

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 17, 2024
@RenechCDDA
Copy link
Member

Ahhh this is the infamous rock crash! It's not your fault that it crashes.

I'll try to give it a poke later today, if I can fix it you'll have to rebase to after the commit that fixes it.

@juur
Copy link
Contributor Author

juur commented Feb 17, 2024

Ahhh this is the infamous rock crash! It's not your fault that it crashes.

I'll try to give it a poke later today, if I can fix it you'll have to rebase to after the commit that fixes it.

I thought it was something ticking when it shouldn't.. thank you so much!

@RenechCDDA
Copy link
Member

Christmas came early, I've put a PR up for it. Sorry this issue came up, I think your PR is quite interesting! I hope we can quickly knock out the crash for you.

@juur juur changed the title initial add earthworms and their delicacies Feb 17, 2024
@fairyarmadillo
Copy link
Contributor

fairyarmadillo commented Feb 17, 2024

I think your kcal value might be too high.

https://www.outdoorlife.com/blogs/survivalist/2014/07/survival-skills-3-safe-bugs-and-how-eat-them/ says that earthworms have about 1 kcal/gram.

Hard numbers for calorie content of actual earthworms is pretty hard to find, but we can fact-check the above claim by comparing it to chicken breast meat, which is 2kcal/gram. Since a whole earthworm is obviously going to be less calorie-dense than a prepared piece of meat of the same size (some percentage of the worm's body is not going to be digestible matter), 1kcal/g sounds right to me.

I'd also suggest bumping the size down to 2g. 3g is like at the outside of what a typical earthworm can get to, and not every one you find is going to be that big.

Lastly if I'm reading the json right, you have it so that digging up a patch of soil will always produce 1-10 earthworms. I see worms a lot where I live but I don't find one every time I turn over a shovel, maybe consider adding a probability there, so that people aren't flooded with worms every time they dig?

Great idea though! If it gets merged I'll add a thing that lets fish and bird mutants enjoy eating worms, because that's funny to me.

https://www.youtube.com/watch?v=3ILoGcSxCAY

@github-actions github-actions bot added Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 18, 2024
@juur
Copy link
Contributor Author

juur commented Feb 18, 2024

I think your kcal value might be too high.

https://www.outdoorlife.com/blogs/survivalist/2014/07/survival-skills-3-safe-bugs-and-how-eat-them/ says that earthworms have about 1 kcal/gram.

Hard numbers for calorie content of actual earthworms is pretty hard to find, but we can fact-check the above claim by comparing it to chicken breast meat, which is 2kcal/gram. Since a whole earthworm is obviously going to be less calorie-dense than a prepared piece of meat of the same size (some percentage of the worm's body is not going to be digestible matter), 1kcal/g sounds right to me.

I'd also suggest bumping the size down to 2g. 3g is like at the outside of what a typical earthworm can get to, and not every one you find is going to be that big.

Lastly if I'm reading the json right, you have it so that digging up a patch of soil will always produce 1-10 earthworms. I see worms a lot where I live but I don't find one every time I turn over a shovel, maybe consider adding a probability there, so that people aren't flooded with worms every time they dig?

Great idea though! If it gets merged I'll add a thing that lets fish and bird mutants enjoy eating worms, because that's funny to me.

https://www.youtube.com/watch?v=3ILoGcSxCAY

I think the current values are a bit too low. 3.2 tonne of soil, giving 183 earthworms. That doesn't feel right. Different Internet sources:

image

This is based on shallow pit digs x10.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 18, 2024
@juur
Copy link
Contributor Author

juur commented Feb 18, 2024

Lastly if I'm reading the json right, you have it so that digging up a patch of soil will always produce 1-10 earthworms. I see worms a lot where I live but I don't find one every time I turn over a shovel, maybe consider adding a probability there, so that people aren't flooded with worms every time they dig?

I've made some changes to reduce the item count, and hopefully balance spamming inventories vs. realistic amounts of food..

@fairyarmadillo
Copy link
Contributor

fairyarmadillo commented Feb 18, 2024

I think the current values are a bit too low. 3.2 tonne of soil, giving 183 earthworms. That doesn't feel right. Different Internet sources:

Yeah but the player isn't going to realistically be able to capture all of those, even if they're trying. We also don't currently have any way to vary their distribution, so a forest, a swamp, a farm, and a construction site are all going to produce the same number of worms, even in the dead of winter. That last part is probably fixable in another PR so I wouldn't worry about seasonal distribution too much, but if you take a shovel and dig a 3 foot pit, most of the worms you get are going to escape while you're busy digging, unless you want to sift every shovelful for worms, which is going to take the work take much longer.

I propose keeping the numbers received from digging low for now, and then later adding a proficiency-based worm grunting method (like in the youtube video I linked) that produces many more with less time and effort. We can make these guys work as bait for fishing, so IMO it's worth quibbling about.

@juur
Copy link
Contributor Author

juur commented Feb 18, 2024

I think the current values are a bit too low. 3.2 tonne of soil, giving 183 earthworms. That doesn't feel right. Different Internet sources:

Yeah but the player isn't going to realistically be able to capture all of those, even if they're trying. We also don't currently have any way to vary their distribution, so a forest, a swamp, a farm, and a construction site are all going to produce the same number of worms, even in the dead of winter. That last part is probably fixable in another PR so I wouldn't worry about seasonal distribution too much, but if you take a shovel and dig a 3 foot pit, most of the worms you get are going to escape while you're busy digging, unless you want to sift every shovelful for worms, which is going to take the work take much longer.

I propose keeping the numbers received from digging low for now, and then later adding a proficiency-based worm grunting method (like in the youtube video I linked) that produces many more with less time and effort. We can make these guys work as bait for fishing, so IMO it's worth quibbling about.

If you have a preference vs the current patch, let me know and I'll change it. I can't merge until the linked bug is resolved anyway.

@fairyarmadillo
Copy link
Contributor

No I think the current count is good, just letting you know there's a method we can add later to get more worms if the player really wants some.

@RenechCDDA
Copy link
Member

As you're still in draft, I think they could be added to the fish bait recipe.

@juur juur marked this pull request as ready for review February 18, 2024 18:33
@Maleclypse Maleclypse merged commit dca0920 into CleverRaven:master Feb 22, 2024
24 of 25 checks passed
@juur juur deleted the worms branch February 23, 2024 18:09
@AcidAntOnAMinefield
Copy link

Toxic metals such as vanadium (0.2 mg·kg−1 DW), lead (0.2 mg·kg−1 DW), cadmium (2.2 mg·kg−1 DW), and arsenic (2.3 mg·kg−1 DW) were found in EAP, which pose safety considerations.

ICP-MS analysis detected 15 minerals in EAP with relatively high levels of calcium, potassium, phosphorus, sodium, iron, zinc, and manganese. However, levels of some heavy metals (cadmium, arsenic, and lead) were detected, which presents food consumption and safety considerations.

The study isn't quite 100% on them being actually completely safe, so I would probably suggest making it so there's some drawback to a character eating them - so far I can only see that they provide 10x more calcium and iron when cooked, compared to raw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants