Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split-off input_context.h from input.h; run iwyu to always include input.h directly #71141

Merged
merged 6 commits into from
Jan 25, 2024

Commits on Jan 22, 2024

  1. iwyu: remove some includes

    accept most changes that only remove includes / forward declarations (don't add any)
    but then actually don't break lightmap.h, so add one
    Brambor committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    429b2d8 View commit details
    Browse the repository at this point in the history
  2. iwyu: run on "input.*"

    accept everything iwyu suggests for these files
    Brambor committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d56b661 View commit details
    Browse the repository at this point in the history
  3. iwyu: always include "input.h" directly; remove excessive includes

    for all files that iwyu reports as (it should add or remove "input.h")
    {
    	add / remove "input.h" according to iwyu;
    	remove everything iwyu reports to remove;
    	while (doesn't compile) {add directly what needs to be added};
    	/* note: thanks to indirect includes, we don't need to include most of what iwyu reports
    	we obey iwyu only for "input.h", everything else is a suggestion if it doesn't compile without it */
    }
    Brambor committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    cee4642 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. split "input.*"

    split-off "input_context.h" and "input_enums.h" from "input.h" and "input_context.cpp" from "input.cpp"
    "input_enums.h" contains things that both of the other header files need.
    Therefor it is included in both of the header files.
    Brambor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8cf6d18 View commit details
    Browse the repository at this point in the history
  2. iwyu: always include "input.h" & "input_context.h" directly; remove e…

    …xcessive includes
    
    for all files that iwyu reports as (it should add or remove "input.h" or "input_context.h")
    {
            add / remove "input.h" and "input_context.h" according to iwyu;
            remove everything iwyu reports to remove;
            while (doesn't compile) {add directly what needs to be added};
            /* note: thanks to indirect includes, we don't need to include most of what iwyu reports
            we obey iwyu only for "input.h" and "input_context.h", everything else is a suggestion
            if it doesn't compile without it */
    }
    Brambor committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0e10f72 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    b8211a0 View commit details
    Browse the repository at this point in the history