Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #71079 #71082

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Fix #71079 #71082

merged 3 commits into from
Jan 19, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jan 19, 2024

Summary

None

Purpose of change

Fixes #71079

Describe the solution

I think I did this in the PR and then deleted thinking it was unnecessary bc I'm a dummy idk

Describe alternatives you've considered

Not breaking something with every PR

Testing

Tested with saves provided by #71079 and #71083 (thanks guys <3)
On vanilla reprod the crash and confirmed the fix prevents it

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 19, 2024
@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Jan 19, 2024
@Procyonae Procyonae marked this pull request as ready for review January 19, 2024 12:00
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 19, 2024
@Maleclypse Maleclypse merged commit 685a518 into CleverRaven:master Jan 19, 2024
32 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portal storm crashes the game / Segmentation fault
2 participants