Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brewing fixes #70144

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Brewing fixes #70144

merged 2 commits into from
Dec 12, 2023

Conversation

Alm999
Copy link
Contributor

@Alm999 Alm999 commented Dec 11, 2023

Summary

Balance "Brewing Recipes Output Correction"

Purpose of change

Most brewing-related recipes have provided inadequate output material, as they didn't took into account that the output liquids have charges, so instead of producing (almost) equal volume of output liquids, they gave just one charge of said liquid (e.g. a recipe for "unfermented vinegar" made just 1/32th of input volume, or 62.5ml from 500ml of input water and juice/berries).

Describe the solution

I've recalculated the output to closely match input volume of base liquid (clean water).

Describe alternatives you've considered

We could dispose of "charges" in liquids (considering, "charges" are being slowly obsoleted) and just produce base items in appropriate quantities, but I believe this is a task for other PR.

Testing

I've tested recipes in-game. They seem to produce correct amounts of product now.

Additional context

Not applicable.

I'm an idiot.
Anyways, correction for absence of distilling/evaporation (that's a different process/recipe) and some comment clean-up.
@github-actions github-actions bot added Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 11, 2023
@Maleclypse Maleclypse merged commit 0eb0a93 into CleverRaven:master Dec 12, 2023
21 of 25 checks passed
@Alm999 Alm999 deleted the Brewing-Fixes branch December 12, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants