Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Innawood] Fix cotton having 10 difficulty #69607

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

fix #69593

Describe the solution

Blame revealed the reason cotton as separate material was added only to make you able to repair cotton items with rags, #54149. Something, that was removed again in #54256; Since otherwise it is a complete copy of outdated cotton json (like lack of repair_difficulty defined or outdated burn data), i decided it is better to remove overwritted cotton entirely, and use vanilla version instead

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod labels Nov 21, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Light-Wave

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 21, 2023
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this should do it for cotton.

The only reason cotton was defined separately before, was so it could be repaired with rags. (Then rags went out anyway and uh... it stayed here.)

@GuardianDll Can you modify the fibercloth entry so that it has a repair_difficulty?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 21, 2023
@Maleclypse Maleclypse merged commit f0e969a into CleverRaven:master Nov 22, 2023
23 checks passed
@GuardianDll GuardianDll deleted the fix_innawood_cotton branch November 22, 2023 07:53
@BjoHart
Copy link
Contributor

BjoHart commented Nov 22, 2023

Can you perhaps make another change?
If you make a garment from fibercloth, you can only repair it with woole.
Is there a way to also allow fibercloth to be repaired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InnaWood] Clothing made from cotton has broken repair skill
5 participants