-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes for martial arts techniques #69111
Misc fixes for martial arts techniques #69111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @Hymore246
Would it make more sense to remove the extra "the" from the monster name instead? |
Then I would have to add the deleted "the" to the rest of the martial art techniques that do not use it, and I'm not sure where else this is called that would have to be revisited too, at least for now this is more simple. |
Doesn't this result in incorrect capitalization as is? i.e. if |
I think it would, yeah, but it would be wrong capitalization or double "the", with martial art techs I can at least modify their messages so "%s" is always after the start of the sentence, I think its always minus "the" but I will load this branch again and make sure. |
It does appear with incorrect capitalization when at the start of a sentence. |
* Correct double "the" in martial arts techniques * Linting * Takedown working for Ninjutsu * Messages rewrite * Linting * Missing documentation
Summary
Bugfixes "Corrects duplicates /the/ in martial arts techs messages"
Purpose of change
It came to my attention that "%s" already includes "the" when referring to a specific monster, and some martial arts techs had "the %s" in their messages, so it was displayed as "the the" in the message log of the game... So I went and fixed all instances of duplicates "the" that I could find in the martial arts techniques!
The messages where "%s" was at the beginning of a sentence were rewritten so their capitalization remains correct.
Ninjutsu was devoid of its unarmed downing technique for mistake in another PR of mine, so i added the same technique in 2 versions, melee and unarmed, to maintain functionality.
Edit: Added missing documentation regarding #69052
Describe the solution
Simple JSON change of displayed text.
Describe alternatives you've considered
Nothing at all!
Testing
It works! No more duplicates.
Additional context