Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add false eoc to Vampvirus checks in Xedra Evolved #64562

Merged
merged 8 commits into from
Mar 27, 2023

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Mar 25, 2023

Summary

None

Purpose of change

Eliminate the roll remainder messages that continue on after the player has gained all the abilities for that stage.

Describe the solution

Ramza said that I needed to use the false_eoc array and since I couldn't find any examples of it in code I've attempted to make one real quick.

Describe alternatives you've considered

None

Testing

Tested and it works better than before.

Additional context

@Maleclypse Maleclypse marked this pull request as draft March 25, 2023 14:05
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions labels Mar 25, 2023
Update vampvirus.json
data/mods/Xedra_Evolved/effects/vampvirus.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/effects/vampvirus.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/effects/vampvirus.json Outdated Show resolved Hide resolved
Maleclypse and others added 2 commits March 25, 2023 10:00
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 25, 2023
@github-actions github-actions bot added the Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies label Mar 26, 2023
@Maleclypse
Copy link
Member Author

Candlebury suggested replacing the ticking of the effect decay with an eoc inside the existing daisy chain similar to

"run_eocs": [
                      {
                        "id": "EOC_PERK_COMBAT_TEMPO_ADD_STACK",
                        "condition": {"or": [{ "u_has_effect": "tempo_counter", "intensity": 2 }, { "u_has_effect": "tempo_ready"} ]},
                        "effect": [
                            {"u_add_effect": "tempo_ready", "duration": "1 seconds"},
                            { "queue_eocs": "EOC_PERK_COMBAT_TEMPO_ADD_STACK", "time_in_future": [ "2 seconds", "2 seconds" ] }
                        ],
                        "false_effect": {  "u_add_effect": "tempo_counter", "duration": "2 seconds"}
                  } 
                ] 

@Maleclypse Maleclypse marked this pull request as ready for review March 26, 2023 05:02
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Mar 26, 2023
@dseguin dseguin merged commit 5b817f2 into CleverRaven:master Mar 27, 2023
@Maleclypse Maleclypse deleted the Vampvirus-false-eoc branch September 24, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants