Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unlimited glare #64022

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix unlimited glare #64022

merged 1 commit into from
Mar 7, 2023

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Mar 7, 2023

Summary

Bugfixes "Limit glare max duration"

Purpose of change

Fixes #64008
I increased glare duration in #62092 bot forgot to add a max cap.

Describe the solution

Limited glare's max duration to one minute.

Describe alternatives you've considered

A longer duration, but differentiating between "seeing stars" glare and "can't see in the dark" glare would take a bit more effort.

Testing

Pre-fix accumulated glare up to 17 minutes outside, post-fix limited to one minute max.
Protection and shelter works as expected.

Additional context

@GuardianDll
Copy link
Member

Are you sure one minute is enough? I am sure i can recover from direct sunlight in my eye lot faster than for a minute

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) labels Mar 7, 2023
@Venera3
Copy link
Member Author

Venera3 commented Mar 7, 2023

Complete dark adaptation takes about ten minutes from bright conditions, but without differentiating between levels of glare it's about the right ballpark.
A relatively readable web source on how all this works

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 7, 2023
@kevingranade kevingranade merged commit 9a5cfab into CleverRaven:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
3 participants