Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.F artifact migration #63975

Merged

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Removes the 0.F Artifact migration that was eating a bunch of artifacts on load. Should fix #63939

Describe the solution

Removes artifact migrations that say "Remove after 0.F"

Describe alternatives you've considered

Waiting for someone else to do this. I do hope irwss checks my solution.

Testing

Additional context

@Maleclypse
Copy link
Member Author

@irwiss I forgot to at you in the description when I mentioned I hope you look over this.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Mar 5, 2023
Copy link
Contributor

@irwiss irwiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all that came up when I looked at this migration yep, git blame also shows #42137 as the PR that introduced the migration so that should be all of it

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 5, 2023
Update savegame_json.cpp
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 5, 2023
@kevingranade kevingranade merged commit c538dc1 into CleverRaven:master Mar 6, 2023
SurFlurer pushed a commit to SurFlurer/Cataclysm-DDA that referenced this pull request Mar 7, 2023
@Maleclypse Maleclypse deleted the Remove-Artifact-migration branch November 29, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[XEDRA Evolved] Certain spell artifacts turns into normal artifact after save load
3 participants