Bugfix - dissection drop rate

[cathalpern]

Summary

Bugfixes "Dissection drop rate"

Purpose of change

Fixes #61423

Describe the solution

Previously, the section to set roll value had a condition where the value was being set, except in cases where the action was dissection. So, the roll value was always 0 for dissection, causing items to never be dropped in some cases. Removing the check that the action is not dissection allows the roll value to get set.

Describe alternatives you've considered

I'm just doing what the smart people said to do

Testing

Debug spawned and killed 10 prototype cyborgs. Was able to successfully harvest a Power Storage CBM from all.

[RenechCDDA]

Well, trying it out now that I got back.

This isn't going to work, because it guarantees the result. Here's a quick test change I made and the results:

(Note: Setting the item group to a count of say 100-1000 produces a seemingly completely random range within those values, regardless of your degree of success or, y'know, roll, so that's... not good either. )

(Reported success rate includes corrected debug output)
Notice we should fail every single one of these dissections but we always get a power storage CBM. Essentially this just breaks it in the opposite direction by guaranteeing we get defined single items regardless of how badly we do on the dissection.

Some other things I'd also like to address to fully fix the issue:

-There's a typo in the debug display on line 362, 19.0f should change to 10.0f (like the line below it). The above images already include this fix, but it's important moving forward.

-Debug output doesn't appear on corpses which define a single item for their dissection drop (e.g. broken cyborg with cyborg_harvest removed).

[cathalpern]

I did think that it was odd that I was successfully harvesting with things like 95% failure chances - but thought maybe that was intentional, in that certain things would always drop based on config.

[I-am-Erk]

So, this does appear to be the correct change after some play testing in the discord. What we need is to go here:

Cataclysm-DDA/data/json/harvest_dissect.json

Line 686 in 6957090

"flags": [ "NO_STERILE", "NO_PACKED", "FILTHY" ],

and add something like

"base_num": [ 0, 3 ],
"scale_num": [ 0.5, 2.5 ]

to each entry in zomborg and broken_cyborg in that file. if someone could add that to this PR or a clone of this PR and test it, I'd be much obliged... preliminary reports are that this should work.

[cathalpern]

Adding scale numbers to dissection JSON and reopening

[I-am-Erk]

I will try to review the JSON end tonight or tomorrow

[RenechCDDA]

Please include the typo fix mentioned earlier, in case this ends up being the preferred solution.

-There's a typo in the debug display on line 362, 19.0f should change to 10.0f (like the line below it). The above images already include this fix, but it's important moving forward.

[mqrause]

A nice to have would be a test that makes sure result numbers are within expectations. Doesn't necessarily have to be part of this PR, though.

[mqrause]

There's nothing wrong with leaving the debug messages in.

[cathalpern]

There's nothing wrong with leaving the debug messages in.

Eh, they were mostly just for checking the numbers as I was testing - don't want to spam the logs with stuff that wouldn't be super meaningful. If other people think the min/max and roll values would be helpful, I can make the messages a little more explicit and add them back. Also instinctive reaction to what felt like leaving a bunch of console.logs in my finalized code haha

[mqrause]

There's a filter for debug messages and I wouldn't consider it spam in the first place. But of course there's also nothing wrong with removing them. And making them more compact and more meaningful is obviously also a good thing.