-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct CMake install locations on *nix #62234
Conversation
I mean I'm still on vacation but I found time to hop on discord today :p |
Ah, thanks, I didn't realize you had opened the second PR already. Because install is effectively broken on *nix right now, do we want to merge this as a temporary fix? (I'm thinking it's find to wait considering I seem to be the first person to notice, unless there's an issue I missed.) |
Co-authored-by: Perry Fraser <[email protected]>
Co-authored-by: Perry Fraser <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
@perryprog could you please resolve conflicts? |
Oops, sorry—been busy with real life so I haven't had a chance to look at this PR. I'll double check that this is still an issue with the merge of #61880, and if so rebase off that. |
675b00b
to
1b64077
Compare
All done; sorry for the delay. @alef, can you confirm this still installs as expected for Windows? It looks good to me on macOS. |
Summary
None
Purpose of change
PR #61225 changed the location some stuff got installed in, which while correct for the Windows style install location, is incorrect for the default *nix style install locations. (
CMAKE_INSTALL_DIR
is by default/usr/local
instead ofc:/Program Files/${PROJECT_NAME}/
according to here.)Describe the solution
Adjust these install locations to be correct for both OS's, hopefully. I'm not sure what the install locations for
gfx/
anddoc/
are intended to be for Windows, so I've set it to what it was previously, which is underDATA_PREFIX
. I'd like it if this can be confirmed before the PR is merged so I can make the default install locations for both of those directories also depend on OS.Describe alternatives you've considered
Testing
Builds and runs on macOS. I'd appreciate it if someone on Windows can test.
Additional context
CC @alef: I'd like to know what would be the correct directories according to what you were trying to do.