Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jian and wakizashi proficiency requirements change #61288

Conversation

Merikona
Copy link
Contributor

Summary

Bugfixes "Tempered jian and wakizashi crafting require quenching proficiency instead of case hardening"

Purpose of change

All hardened blades use the case hardening proficiency to craft, and all tempered blades use the quenching proficiency to craft. Tempered jian and wakizashi do not currently follow this pattern due to an error. This PR aligns those two recipes with the others.

Describe the solution

Simple 2 line json fix.

Describe alternatives you've considered

N/A

Testing

Tested on latest experimental to see that the two recipes have changed.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Sep 26, 2022
@Merikona Merikona changed the title Case hardening to quenching Jian and wakizashi proficiency requirements change Sep 26, 2022
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 26, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 26, 2022
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 26, 2022
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 26, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 26, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit deccd54 into CleverRaven:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants