Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for lost submissive profession #61236

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Raiksler
Copy link
Contributor

Summary

Bugfixes "Fixed matchbox disappearing bug in lost submissive profession"

Purpose of change

When you start the game with the profession "lost submissive", the box of matches, which is the starting item of this profession, disappears. This is due to the fact that none of the clothing items of this profession has pockets. (It's literally a simple latex suit haha)

Describe the solution

I gave the box of matches the "auto-wield" flag, now the character correctly appears in the world with a box of matches in his hands.

Describe alternatives you've considered

Remove the matchbox from the list of starting items. But it would make starting in the "escape from the manor" scenario less variable when playing as this character.

Testing

I created a character and made sure everything works as expected

Additional context

The original idea was to add a candle to a box of matches as starting items when starting this profession. The bug caused by the lack of pockets was discovered by accident. I think it would be great to add a candle as a starting item (because it fits perfectly into the context of the profession and will make the "escape from the manor" scenario more variable), but I can't think of where to put it.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 24, 2022
@PatrikLundell
Copy link
Contributor

Have you made sure this change doesn't screw up regular usage of matchboxes by e.g. placing those in the hands rather than the inventory of every character who picks those up (including the one targeted for the change of encountering matchboxes later)?

If the reason for the change is to help with a particular start location you might consider modifying that start location(s) to always have those items in the starting room(s). I don't think it matters much for anyone encountering these items in those rooms when exploring a mansion they've found, as neither item is something that would have to be made sure it's rare.

@Raiksler
Copy link
Contributor Author

Have you made sure this change doesn't screw up regular usage of matchboxes by e.g. placing those in the hands rather than the inventory of every character who picks those up (including the one targeted for the change of encountering matchboxes later)?

If the reason for the change is to help with a particular start location you might consider modifying that start location(s) to always have those items in the starting room(s). I don't think it matters much for anyone encountering these items in those rooms when exploring a mansion they've found, as neither item is something that would have to be made sure it's rare.

Yes, this change cannot affect the use of a matchbox, as this is a simple professions.json change that only affects the location of the matchbox when starting for this specific profession.
The reason for the change is that at the moment, we are facing an error screen when trying to start a game with this profession. I think I didn't point it out clearly enough in the "purpose of change" section.

@dseguin dseguin merged commit 4a39d13 into CleverRaven:master Sep 27, 2022
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants