Pockets: soft nested containers respect priority settings #57700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
#54941 made it so that items are never inserted into soft nested pockets. The rationale was that it doesn't improve volume management and only increases the retrieval cost of the item. The issue is that some containers have special properties despite being "soft", like the dimensional bag from Magiclysm.
Players should expect that manually setting pocket priority takes precedent over whether it's soft or not.
Describe the solution
Respect pocket priority settings when inserting items into containers.
Describe alternatives you've considered
Adding flags/fields to pocket data for specifying special priority behaviours.
Testing
Added a couple of test cases to verify that pocket priority is respected for any nested container:
Additional context