Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
It looks like #57446 introduced some mapgen issues. This is causing CI tests to fail when the No Hope mod is loaded.
Examples of failed GHA runs:
https://github.com/CleverRaven/Cataclysm-DDA/runs/6378274579
https://github.com/CleverRaven/Cataclysm-DDA/runs/6378882185
Describe the solution
Use palette definitions, mainly using the same definitions as the existing
house_08
OMT (standard_domestic_palette
andstandard_domestic_palette_abandoned
).I also moved the new terrain and furniture defs to a separate palette for consistency.
Describe alternatives you've considered
Testing
Ran the offending test:
Additional context
(How did the original PR pass all tests?)