Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prof_quenching to tempered armor recipes #57596

Merged
merged 1 commit into from
May 10, 2022

Conversation

rusmal
Copy link
Contributor

@rusmal rusmal commented May 10, 2022

Summary

None

Purpose of change

When crafted from raw materials, suits of tempered plate armor (heavy, regular, and light) use the Quenching proficiency. However, their component parts (chestplates, arm guards, and leg guards) do not, so it was possible to bypass the need for Quenching by crafting those first and then using them to craft the full suit. I added the proficiency to those component parts.

Describe the solution

Added prof_quenching to recipes for heavy/regular/light chestplates/arm guards/leg guards

Describe alternatives you've considered

Remove the mention of "quenching" from the recipes for the component parts, though from what little I know about blacksmithing, I'm not sure if they could be called "tempered" at that point.

Testing

Checked the recipes in-game and confirmed the proficiency appears in the crafting menu.

Additional context

This is my first PR, so please let me know if I've done anything incorrectly. Reading over the changelog guidelines, this seems like a change that might just clutter the log, but if anyone feels differently I'm happy to edit the summary.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 10, 2022
@Drew4484
Copy link
Contributor

You've got it correct, the armor is quenched and tempered, which should give the proficiency. Good catch.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 10, 2022
@dseguin dseguin merged commit b392827 into CleverRaven:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants