Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
remove_npc
effect doesn't work because:the result is that the random encounter NPCs from #56629 and #56940 never despawn
Fixes #57549
Describe the solution
OM_MOVE
so it doesn't spawn spurious NPCs if there's no evac_center on the overmapDescribe alternatives you've considered
De/serializingobsoletenpc.idz
instead of 3: this would work, but not fix the issue in existing savesTesting
"one_in_chance"
to 1 for this)Try the repro steps from #57549 too
Additional context
N/A