Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMA] Weapon Categories: Tiger Claw + update great axes category #57214

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

catdach
Copy link
Contributor

@catdach catdach commented Apr 27, 2022

Summary

Balance "Weapon categories for Tiger Claw"

Purpose of change

part of #56105

Describe the solution

Added the following categories to Tigre Claw: "CLAWS", "HAND_AXES", "GREAT_AXES", "EXEMPLAR_WEAPON_TIGER_CLAW"

New weapon category: "Hand Axes" - hatchet, Ice axe, crash axe - (One handed axes.)

Additions to "Great Axes": wood axe, copper axe, stone axe (These probably should have been in "great axes" to begin with, I just forgot about them at the time.)

New MMA exclusive category: "exemplar weapon (tiger claw)" - Kukri
I plan on giving all the DND martial arts a special weapon category for their exemplar weapons and tie it to some special buffs and/or techniques for using them. Decided to throw this in for now so that I can keep the kukri without adding the "knives" category. (As for those "special buffs and/or techniques"; that's out of the scope of this PR, I'll add them later)

removed: stone axe head and metal axe head
These are essentially just sharp rocks, they really aren't martially viable weapons.

Describe alternatives you've considered

Adding the pickaxe to "great axes". It's a bit too much of a stretch for me to be comfortable with.

Adding the "BLADED_FARMING" category to represent the Kama. I would be more comfortable doing this if the category was more exclusive to sickles; I could also make a new category for that, but I'm not going to do that just for the kama

Testing

before:
image
after:
image

Additional context

original PR for Tiger Claw: #41381

added weapon categories for Tiger Claw
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Martial Arts Arts, Techniques, weapons and anything touching martial arts. Mods Issues related to mods or modding Mods: MMA Mythical Martial Arts mod Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions labels Apr 27, 2022
@catdach catdach mentioned this pull request Apr 27, 2022
12 tasks
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 27, 2022
@dseguin dseguin merged commit 963495a into CleverRaven:master Apr 29, 2022
@catdach catdach deleted the MMA_weapon_cats_Tiger_Claw branch July 16, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Martial Arts Arts, Techniques, weapons and anything touching martial arts. Mods: MMA Mythical Martial Arts mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants