inv_ui: check only allowed parents in indent sort #56867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
dseguin
added
Info / User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Indented sorting in inventory UIs can lead to crashes if the checked parents are of an unexpected type
Fixes: #56827
Fixes: #56887
Describe the solution
Only consider parents allowed by the preset
Describe alternatives you've considered
Disabling indented sorting for the problematic preset: this only sweeps the issue under the rug
Adding a safety check to the problematic preset: this should NOT be necessary
Testing
Wear 2 backpacks and insert one 7-round shotgun in each, then activate a bottom mount. There should be no crash.
All indented inventory UIs should look the same
Additional context
I introduced this bug in #53373