-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragon skin vest update #56773
Dragon skin vest update #56773
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
(I know you were interested in looking at this @bombasticSlacks, so feel free to offer input if you like) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like what you've got and the write-up is fantastic! I wrote some very pedantic armor nerd stuff for suggestions.
Also might be a decent addition to the lab security officer drops. I'd have to look when I'm on my PC but iirc they already have a body armor spawn pool, could be a rare drop there. It would need to be bundled with a lbv or the tac vest tho. Can't imagine many people would want to lug one of these around but maybe if they were dealing with containment aliens they might!
One last note it looks like it does have molle webbing on the front. So it should probably have the MOLLE_ATTACH and MOLLE_DETACH actions with the same values as the US Balistic Vest. |
@Ilysen Just to let you know, you have two issues marked by GitHub Actions that should be easy to fix (missing double space and extra str_pl that isn't needed). :) |
Summary
Content "Modernized the dragon skin vest"
Purpose of change
This type of armor has in the game for a really long time, and it's been kind of left by the wayside. There's a very interesting story behind real-life dragon skin armor that seems to not be mentioned or referenced, and I felt like the armor could use some modernization.
Describe the solution
lightceramic
material by replacing its instances with regular ceramic. While doing my research for this, I couldn't find any source of information stating that the disks could be repaired/replaced; part of the reason that they failed in real life is that they're held in a layer with epoxy that delaminated under environmental tests. The disks aren't actually stitched in place like the lamellar Kevlar vest implied. If anyone can find a source that rebuffs my own findings on this, please let me know! I'd be happy to remove that part of this PR if I'm actually wrong.Describe alternatives you've considered
Testing
Spawned in a dragon skin vest with debug and read through the description to make sure it looked okay. Attempted to disassemble the vest, but got no results. Spawned in a zombie and let it whack me a bunch of times to check its new protection.
Additional context
The description in this image is slightly outdated, but the protection values etc. are all up-to-date.