Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragon skin vest update #56773

Merged
merged 6 commits into from
Apr 18, 2022
Merged

Dragon skin vest update #56773

merged 6 commits into from
Apr 18, 2022

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Apr 13, 2022

Summary

Content "Modernized the dragon skin vest"

Purpose of change

This type of armor has in the game for a really long time, and it's been kind of left by the wayside. There's a very interesting story behind real-life dragon skin armor that seems to not be mentioned or referenced, and I felt like the armor could use some modernization.

Describe the solution

  • Added a long new description to the dragon skin vest, in line with the protein ration's description. In a fictionalized story based on real life dragon skin, it describes what the armor was meant to do, the problems it faced, and what it was like by the time the Cataclysm happened. It draws heavily from the real-world controversies, but using a fake company name (Meridian Ballistics).
  • The dragon skin vest now weighs ~21.5 kg (or 47.5 pounds), in line with its real-life weight.
  • Revamped protection to use partial coverages. It now covers 90% of the torso, with 100% of that covered by nylon of 1 mm thickness and 90% covered by ceramic of 6.4 mm thickness, with an additional 30% layer of 6.4 mm ceramic. The ceramic thickness is also based on the real-life model (where the discs are 2 inches across and 6.4 mm thick), but I couldn't find a source on the fabric itself. The second layer of ceramic was suggested by @bombasticSlacks and is meant to represent spots where two disks overlap.
  • Pre-Cataclysm price adjusted to $5000. Post-Cataclysm price ($60) remains unchanged.
  • Obsoleted the lamellar Kevlar vest and ceramic disks, and removed the lightceramic material by replacing its instances with regular ceramic. While doing my research for this, I couldn't find any source of information stating that the disks could be repaired/replaced; part of the reason that they failed in real life is that they're held in a layer with epoxy that delaminated under environmental tests. The disks aren't actually stitched in place like the lamellar Kevlar vest implied. If anyone can find a source that rebuffs my own findings on this, please let me know! I'd be happy to remove that part of this PR if I'm actually wrong.
  • The dragon skin vest can now attach MOLLE accessories, with a total capacity of 10 (equal to the US ballistic vest).

Describe alternatives you've considered

  • Having different thickness or coverage for the fabric part. I couldn't find a proper source about the real-life thickness, so I opted for what's also used on other ballistic armors when it comes to synthetic fabric.
  • Keeping the lamellar Kevlar vest in some form and polishing it up. Like I mentioned in the above portion, I'm still open to doing this; I just couldn't find any source that mentioned it was possible. I think that the inability of the DSV to be repaired makes it a little more interesting, especially given the background behind it, but I'm not all-in on keeping that around.
  • I'm sure that the description can use a lot of refinement and improvement. I wrote out a much longer version initially, and gradually trimmed it down until I got it to a version that I thought presented the info in a succinct(ish) way without losing any of the details, but it's still really long.

Testing

Spawned in a dragon skin vest with debug and read through the description to make sure it looked okay. Attempted to disassemble the vest, but got no results. Spawned in a zombie and let it whack me a bunch of times to check its new protection.

Additional context

The description in this image is slightly outdated, but the protection values etc. are all up-to-date.
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 13, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This type of ballistic vest once promised to be the future of body armor, claiming to allow a greater range of movement than conventional ballistic vests as well as better protection. Created by the now-defunct company Meridian Defense, it features a unique design consisting of overlapping ceramic disks, and was once famously demonstrated on TV absorbing high-energy rifle rounds at point blank.\n\nThe US Army quickly snapped up several hundred units of the armor, but testing quickly revealed they were extremely heavy, weighing almost fifty pounds, and that the design failed spectacularly in environmental tests. After a series of investigations, claims of fraud, and court hearings, Meridian went bankrupt, and the Department of Justice soon dropped this design from its cerifications.\n\nThere were no known users of these vests by the time that the world ended; the one before you now was either an original production in the hands of a collector, or a similar design from a different company. Whatever the case may be, you have one now, in all its unwieldy glory.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Ilysen
Copy link
Contributor Author

Ilysen commented Apr 13, 2022

(I know you were interested in looking at this @bombasticSlacks, so feel free to offer input if you like)

Copy link
Contributor

@bombasticSlacks bombasticSlacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you've got and the write-up is fantastic! I wrote some very pedantic armor nerd stuff for suggestions.

Also might be a decent addition to the lab security officer drops. I'd have to look when I'm on my PC but iirc they already have a body armor spawn pool, could be a rare drop there. It would need to be bundled with a lbv or the tac vest tho. Can't imagine many people would want to lug one of these around but maybe if they were dealing with containment aliens they might!

data/json/recipes/armor/torso.json Show resolved Hide resolved
data/json/items/armor/ballistic_armor.json Show resolved Hide resolved
data/json/items/armor/ballistic_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/ballistic_armor.json Outdated Show resolved Hide resolved
@bombasticSlacks
Copy link
Contributor

One last note it looks like it does have molle webbing on the front. So it should probably have the MOLLE_ATTACH and MOLLE_DETACH actions with the same values as the US Balistic Vest.

@Faalagorn
Copy link
Contributor

@Ilysen Just to let you know, you have two issues marked by GitHub Actions that should be easy to fix (missing double space and extra str_pl that isn't needed). :)

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 16, 2022
@bombasticSlacks bombasticSlacks merged commit 4044cfe into CleverRaven:master Apr 18, 2022
@Ilysen Ilysen deleted the dragon-skin-update branch April 18, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants