-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dissection separation and an increase in sample availability #56608
Conversation
Remind me to never agree to do this again
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
was worn out, kept making a mistake setting this table
sorry for excessive test runs
sorry about the repeated failures, the test suite isnt failing for me and im exhausted trying to fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetizing mutagen_ingredients.json
makes it harder to review but I didn't find any issues up through that file. I'll try and finish reviewing tonight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates an opportunity to do a much bigger DinoMod harvest overhaul since a bunch of stuff was duplicated for CBM purposes, but I'll handle that with a follow up PR. Good stuff!
Co-authored-by: LyleSY <[email protected]>
Co-authored-by: LyleSY <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through Insect I wasn't sure what method you used to determine how many samples a given creature gave. Was it weight, hp, danger, or some other method you used? Would you be able to include in the documentation some general guidelines as to how to decide what size of the sample's a given creature should drop? If it's all by feel no sense in writing any documentation but I wanted to check in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aftershock and vanilla look good, I had a questions in a couple of places. This is very excellent. Thank you!
It's by feel and a combination of all of them along with other sources of sample availability and mutation category rarity, I don't think there's a way to consistently document it. I was aiming for a balance of attainability versus how "normal" the mutation category is, more than a strict rubric of size -> sample count or similar methods. |
Co-authored-by: Maleclypse <[email protected]>
That is what I expected and there's nothing wrong with that. edit: I unresolved the beast rabbit one to make sure you see my response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you make any changes you think need further review but otherwise this is great and I trust your judgement.
Thank you! |
Summary
Infrastructure "Dissection tables separate from harvest tables, and relevant monsters dissect to samples"
Purpose of change
Dissection required a permutation of tables. For example, multiple harvest entries different only in dissection sample existed for furred mammals. Additionally, most relevant monsters didn't drop a reasonable amount of samples.
Describe the solution
Most non-zombified monsters dissect to a sample, all samples now exist, a set of tables for those samples exist, and dissect is a separate entry from harvest.
Adds a couple new monsters to lacking categories.
Describe alternatives you've considered
Testing
Disssected and butchered enemies that have samples, bionics and no dissection drop.
Additional context