Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissection separation and an increase in sample availability #56608

Merged
merged 23 commits into from
Apr 18, 2022

Conversation

MylieDaniels
Copy link
Contributor

@MylieDaniels MylieDaniels commented Apr 5, 2022

Summary

Infrastructure "Dissection tables separate from harvest tables, and relevant monsters dissect to samples"

Purpose of change

Dissection required a permutation of tables. For example, multiple harvest entries different only in dissection sample existed for furred mammals. Additionally, most relevant monsters didn't drop a reasonable amount of samples.

Describe the solution

Most non-zombified monsters dissect to a sample, all samples now exist, a set of tables for those samples exist, and dissect is a separate entry from harvest.
Adds a couple new monsters to lacking categories.

Describe alternatives you've considered

Testing

Disssected and butchered enemies that have samples, bionics and no dissection drop.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions labels Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • deathrattle serpent
  • deathrattle serpents

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 5, 2022
@MylieDaniels MylieDaniels changed the title Dissection Dissection separation and an increase in sample availability Apr 5, 2022
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) labels Apr 5, 2022
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Apr 5, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 5, 2022
sorry for excessive test runs
sorry about the repeated failures, the test suite isnt failing for me and im exhausted trying to fix that
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetizing mutagen_ingredients.json makes it harder to review but I didn't find any issues up through that file. I'll try and finish reviewing tonight.

Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates an opportunity to do a much bigger DinoMod harvest overhaul since a bunch of stuff was duplicated for CBM purposes, but I'll handle that with a follow up PR. Good stuff!

data/mods/DinoMod/harvest.json Outdated Show resolved Hide resolved
data/mods/DinoMod/harvest.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 5, 2022
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through Insect I wasn't sure what method you used to determine how many samples a given creature gave. Was it weight, hp, danger, or some other method you used? Would you be able to include in the documentation some general guidelines as to how to decide what size of the sample's a given creature should drop? If it's all by feel no sense in writing any documentation but I wanted to check in case.

data/json/monsters/bird.json Outdated Show resolved Hide resolved
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aftershock and vanilla look good, I had a questions in a couple of places. This is very excellent. Thank you!

data/json/monsters/mammal.json Outdated Show resolved Hide resolved
data/json/monsters/mammal.json Show resolved Hide resolved
data/json/monsters/nether.json Show resolved Hide resolved
@MylieDaniels
Copy link
Contributor Author

MylieDaniels commented Apr 6, 2022

Going through Insect I wasn't sure what method you used to determine how many samples a given creature gave. Was it weight, hp, danger, or some other method you used? Would you be able to include in the documentation some general guidelines as to how to decide what size of the sample's a given creature should drop? If it's all by feel no sense in writing any documentation but I wanted to check in case.

It's by feel and a combination of all of them along with other sources of sample availability and mutation category rarity, I don't think there's a way to consistently document it. I was aiming for a balance of attainability versus how "normal" the mutation category is, more than a strict rubric of size -> sample count or similar methods.

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding labels Apr 6, 2022
@Maleclypse
Copy link
Member

Maleclypse commented Apr 6, 2022

Going through Insect I wasn't sure what method you used to determine how many samples a given creature gave. Was it weight, hp, danger, or some other method you used? Would you be able to include in the documentation some general guidelines as to how to decide what size of the sample's a given creature should drop? If it's all by feel no sense in writing any documentation but I wanted to check in case.

It's by feel and a combination of all of them along with other sources of sample availability and mutation category rarity, I don't think there's a way to consistently document it. I was aiming for a balance of attainability versus how "normal" the mutation category is, more than a strict rubric of size -> sample count or similar methods.

That is what I expected and there's nothing wrong with that. edit: I unresolved the beast rabbit one to make sure you see my response.

Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you make any changes you think need further review but otherwise this is great and I trust your judgement.

@MylieDaniels
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants