Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBM Spawn Cleanup #56552

Merged
merged 5 commits into from
Apr 11, 2022
Merged

CBM Spawn Cleanup #56552

merged 5 commits into from
Apr 11, 2022

Conversation

Drew4484
Copy link
Contributor

@Drew4484 Drew4484 commented Apr 3, 2022

Summary

Content "Removes CBMs inappropriate locations."

Purpose of change

Removes some remaining Earth CBM spawn locations.

Describe the solution

Removes non-Exodii CBM spawns and drops from several locations and loot lists.

Describe alternatives you've considered

None.

Testing

Additional context

Left the broken cyborg as-is. Left lab specials.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions labels Apr 3, 2022
@Night-Pryanik
Copy link
Contributor

I'm VERY MUCH against this.

Screw retcon in general and screw Exodii in particular. I want Earth-made bionics, not some goddamn weirdo mumbo-jumbo aliens.

Removing autodoc_installation_programs from two loot lists means they won't spawn anywhere at all.

@NetSysFire NetSysFire added the Bionics CBM (Compact Bionic Modules) label Apr 3, 2022
@NetSysFire
Copy link
Member

I think they are just trying to make it work with the current lore chosen. I would discuss that with @I-am-Erk. I don't like the Exodii either but luckily there is the Dark Days of the Dead mod.

@Broken27
Copy link
Contributor

Broken27 commented Apr 3, 2022

Shouldn't this wait until the Exoddi are actually complete?

@SariusSkelrets
Copy link
Contributor

SariusSkelrets commented Apr 3, 2022

Yeah IIRC the plan is to wait for the Exodii are fully done before getting rid of earth-cbm. That's why labs still have them

I want Earth-made bionics

DDA-earth have power armor, which in a pre-apocalypse scenario is almost better on all fronts than bionics.

Earth-bionics would've been conceived before the end, where you want to have replacements if someone can't do what you're asking them and where not being able to doff your equipment is a very big drawback

Since bionics, unlike power armors, need invasive surgeries before use, are a pain to repair, can't be transfered or removed without harming the owner and thus are unsuitable for mass use it's very unlikely they would've be anything else than power armor extensions or a select few bionics sold as harmless gadgets to civillans

Humans from another universe that didn't cared about the drawbacks and impracticality of bionics (the Exodii) allow to simply skip that problem while adding CBMs in the core progression, getting rid of failure chance that forced to grind skills before installation and removing the CBM lab loot RNG

@Xaritscin
Copy link
Contributor

Xaritscin commented Apr 3, 2022

Question. should this also apply to Anthills? the CBM you get there is rare to spawn i think but its not really gamebreaking.

@esotericist
Copy link
Contributor

guys, this is a draft. that means it's not intended to go in yet.

@github-actions github-actions bot added the NPC / Factions NPCs, AI, Speech, Factions, Ownership label Apr 3, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod and removed json-styled JSON lint passed, label assigned by github actions labels Apr 4, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 4, 2022
@a-chancey
Copy link
Contributor

I'm VERY MUCH against this.

Screw retcon in general and screw Exodii in particular. I want Earth-made bionics, not some goddamn weirdo mumbo-jumbo aliens.

Removing autodoc_installation_programs from two loot lists means they won't spawn anywhere at all.

Autodoc self installation is planned to be going away, IIRC. I believe the plan was that you’d need an operator (doctor NPC at Tacoma or Hub01) after a quest to bring them an autodoc, so the installation programs will be useless

@a-chancey
Copy link
Contributor

Question. should this also apply to Anthills? the CBM you get there is rare to spawn i think but its not really gamebreaking.

I believe #55999 already took care of anthill CBM spawns, among others

@Drew4484 Drew4484 marked this pull request as ready for review April 5, 2022 00:15
@kevingranade
Copy link
Member

The bionics_common group continues to spawn in labs after this, "bionics" spawns in labs and microlabs, bionics_mil spawns nowhere, which might be a bit of a problem if there are any items unique to it.

Overall I'll sit on this for a bit, but given the above I'm not seeing a problem, we've had a ton of availability creep over time with bionics appearing in some truly silly places (storage units?), and ratcheting that back is reasonable to do independent of making them more available via Exodii or elsewhere.

As for rejecting overall development direction, that's a non-starter, CBMs are moving primarily to Exodii, end of story.

@kevingranade kevingranade merged commit 55a4450 into CleverRaven:master Apr 11, 2022
@Drew4484 Drew4484 deleted the CBM-cleanup branch April 11, 2022 02:46
@a-chancey
Copy link
Contributor

The bionics_common group continues to spawn in labs after this, "bionics" spawns in labs and microlabs, bionics_mil spawns nowhere, which might be a bit of a problem if there are any items unique to it.

Overall I'll sit on this for a bit, but given the above I'm not seeing a problem, we've had a ton of availability creep over time with bionics appearing in some truly silly places (storage units?), and ratcheting that back is reasonable to do independent of making them more available via Exodii or elsewhere.

As for rejecting overall development direction, that's a non-starter, CBMs are moving primarily to Exodii, end of story.

I missed this until I just got the merge notification.

CQB is now unattainable, but all of the other mil_bionics seem to be in the bionics group now.

I can create an issue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants