Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate inline weakpoint names #56201

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Mar 18, 2022

Summary

None

Purpose of change

Faalagorn on discord mentioned that the weakpoint name strings weren't showing up in Transifex.

Describe the solution

Add a check in the monster parser in lang/string_extractor/parsers/.

Describe alternatives you've considered

Testing

./lang/update_pot.sh
...

#. ~ Sentence fragment describing a weakpoint for monster "massive stag beetle"
#. ~ Sentence fragment describing a weakpoint for monster "giant diving beetle"
#: data/json/monsters/insect_spider.json
#: data/mods/TropiCataclysm/monsters/tropical_insect_spider.json
msgid "a soft section of chitin"
msgstr ""

#. ~ Sentence fragment describing a weakpoint for monster "massive stag beetle"
#. ~ Sentence fragment describing a weakpoint for monster "giant diving beetle"
#: data/json/monsters/insect_spider.json
#: data/mods/TropiCataclysm/monsters/tropical_insect_spider.json
msgid "a crack in the chitin"
msgstr ""

...

Additional context

@dseguin dseguin requested a review from BrettDong as a code owner March 18, 2022 22:11
@github-actions github-actions bot added [Python] Code made in Python Translation I18n json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 18, 2022
@ZhilkinSerg ZhilkinSerg merged commit 8728953 into CleverRaven:master Mar 20, 2022
@dseguin dseguin deleted the extract_mon_weakpoint branch March 20, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants