Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tacoma grammar updates. Change knife spear to simple knife spear #56188

Merged
merged 2 commits into from
Mar 20, 2022
Merged

Tacoma grammar updates. Change knife spear to simple knife spear #56188

merged 2 commits into from
Mar 20, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Mar 18, 2022 •
edited
Loading

Summary

Bugfixes "Tacoma grammar updates. Change mission to simple knife spear."

Purpose of change

Improve grammar. Ported changes from #55690
I also included changing to the simple knife spear because it's affecting the same line of text and am trying to avoid having translators do updates twice.

Describe the solution

Fix grammar

Describe alternatives you've considered

None

Testing

Tested as part of #55690, just porting it to a sizable PR.

Additional context

None

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 18, 2022
@haveric haveric marked this pull request as ready for review March 18, 2022 17:44
@ZhilkinSerg ZhilkinSerg merged commit 27a0937 into CleverRaven:master Mar 20, 2022
@haveric haveric deleted the tacoma-grammar branch March 20, 2022 13:31
@haveric haveric mentioned this pull request Mar 20, 2022
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haveric @ZhilkinSerg