Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rev vcpkg cachekeys again. #56073

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Conversation

akrieger
Copy link
Member

Something changed and the cache we've kept around forever isn't hitting right again.

Summary

None

Purpose of change

The vcpkg cache is useless if it's not actually hitting. It's hitting in github cache but isn't actually usable because something changed about vcpkg's internal cachekey calculations so it considers the retrieved artifacts worthless. Just bump the keys to start fresh again.

Describe the solution

Make all the cachekeys move to appended -1. Fix the discrepancy between the release build and 'matrix' builds too.

Describe alternatives you've considered

Testing

Additional context

Something changed and the cache we've kept around forever isn't hitting right again.
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 13, 2022
@ZhilkinSerg ZhilkinSerg merged commit 20b4ebb into CleverRaven:master Mar 13, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 13, 2022
@akrieger akrieger deleted the rev_keys_again branch March 13, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants