Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate hotkeys from debug menu #56058

Merged
merged 4 commits into from
Mar 20, 2022

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Make debug menu more concise, easier to read and to translate.

Describe the solution

Remove duplicated hotkeys in some of the debug menu.

Describe alternatives you've considered

None.

Testing

Compiled the game, opened the menu:
before:
screenshot_2022-03-12-145010
after:
screenshot_2022-03-12-150749
No idea why the effects are shown on the first screenshot and not the other, although it doesn't seem to be related, unless the window size causes this in which way it should be fixed in a separate PR.

Additional context

Originally posted by me on Discord. Polish translation already had removed hotkeys for a while.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 12, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Print temprature

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

src/debug_menu.cpp Outdated Show resolved Hide resolved
@Faalagorn
Copy link
Contributor Author

Rolling back to a regular version doesn't display needs as well, so it seems not to be related to this PR, something to take a look at I guess:
screenshot_2022-03-12-153726

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 12, 2022
@Maleclypse Maleclypse added the Controls / Input Keyboard, mouse, keybindings, input UI, etc. label Mar 12, 2022
@ZhilkinSerg ZhilkinSerg reopened this Mar 16, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 18, 2022
@ZhilkinSerg ZhilkinSerg merged commit 3a0a151 into CleverRaven:master Mar 20, 2022
@Faalagorn Faalagorn deleted the patch-1 branch March 20, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants